Skip to content

fix(ci): pause search clock without wall-time races - #9695

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/staging-audit-clock-cleanup
Nov 5, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/staging-audit-clock-cleanup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Search acceptance can fail before exercising its navigation assertion because the browser clock has already passed the host-selected pause time. Freeze its wall time before pausing at that exact instant, then restore normal time during cleanup. The held-admission race and every existing assertion remain unchanged.

Also restore two existing TSDoc blocks to the declarations they document after helper extraction.

Type of Change

  • Bug fix
  • Documentation

Testing

  • A completed hosted Search run demonstrates the pre-fix failure: pauseAt: Cannot fast-forward to the past.
  • Independently checked the mechanism against the pinned Playwright clock implementation.
  • Hosted CI validates formatting, audits, types, tests, builds and selected acceptance suites; no local builds or test suites were run.
  • No product behavior, test skips, retries or timeout budgets change.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests updated and passing in hosted CI
  • No new warnings introduced by design
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 5, 2026 1:57am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge; no actionable issues were found.

Summary

Updates the Search acceptance test to freeze wall time before pausing at that exact instant.

  • The Search acceptance test pauses at a fixed browser time.
  • The comparison and link-view notes sit above their declarations.

Reviews (1) · Last reviewed commit: "fix(ci): pause search clock without wall..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit de3ad2f into staging Nov 5, 2026
61 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/staging-audit-clock-cleanup branch November 5, 2026 01:59

This branch was previously deployed

1 inactive deployment
Preview — e4f0e89b Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant