Skip to content

fix(search): describe connection availability accurately #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 5, 2026
Merged

fix(search): describe connection availability accurately #9699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...space/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,7 @@ function LiveSearchResults({
{!isFetching && data?.live && accounts.length === 0 && (
<div className='flex items-center gap-2 px-2 py-2'>
<p role='status' className='text-[var(--text-muted)] text-caption'>
{filters.source
? 'You haven’t connected this app.'
: 'Connect your apps to search them.'}
No connected apps are available for this search.
</p>
<ChipLink
variant='border'
Expand Down
2 changes: 1 addition & 1 deletion apps/sim/scripts/test-organization-search-e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ try {
assert.equal(body.query, 'Launch notes')
// The seeded member has connected no account, so nothing was searched.
await expect(
page.getByText('Connect your apps to search them.', { exact: true })
page.getByText('No connected apps are available for this search.', { exact: true })
).toBeVisible()
await expect(page.getByText('Search found no results.', { exact: true })).toHaveCount(0)
await expect(page.getByRole('link', { name: 'Connect apps' })).toHaveAttribute(
Expand Down
Loading