Repository navigation
fix(desktop): keep signed release builds off shared caches - #9701
Merged
Merged
Conversation
Restore no caches in the signed build job, and require a manual dispatch to run from the tag it builds, so it never executes another ref's code in a run that can write default-branch caches.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThe PR keeps signed desktop builds off shared caches and requires manual builds to run from the requested tag.
|
5 of 6 tasks
Collaborator
Author
|
Dispatch results, unsigned and unpublished, from a temporary tag that has since been deleted:
That run showed |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildjob restores no caches, so nothing it signs can come from a cache another run wroteGITHUB_REF=refs/tags/$VERSION) instead of checking out a tag named in an input, so a default-branch run never executes another ref's code and a dispatch's caches stay scoped to its taggithub.sha, which removes thecommitoutputhashFilesguard,test:e2ebranch), since a dispatch now always runs the tag's own workflowTags cut before this merges still run their own older workflow when dispatched from the tag, including its Electron cache restore.
Type of Change
Testing
actionlinton the workflowdesktop-e2eand CI on this PRChecklist
test-auditauthoring gate)