Repository navigation
fix(falai): bound pricing lookups and correct result handling - #9706
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[High impact] The PR appears safe to merge, with no new actionable issues found. SummaryThis PR bounds Fal.ai pricing and result requests while preserving charge records when delivery fails.
Both earlier concerns are addressed: delivery failures retain reconciliation metadata, and successful shared prices are cached even when their only waiting caller stops.
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Passed 98 focused provider-boundary tests; full root
bun run testwithVITEST_MAX_WORKERS=6(3,455 app files, 39,525 app tests); lint; all 62 audits; workspace type-check; test-type ratchet; block-registry check; and generated-artifact checks. Regression cases cover concurrent pricing, credential isolation, cache expiry, Retry-After recovery, cancellation, receipt identity, rejected results, and declared/streamed image limits. Twelve guard-removal checks and reproduced cancellation, terminal queue-error, and concurrent-cooldown regressions demonstrate that the regressions fail when their corresponding protections are removed.Checklist
test-auditauthoring gate)