Repository navigation
revert(org): hold the org view and People redesigns for #9687 - #9740
Conversation
…ign system (#9708)" The redesigned org view ships all at once with #9687. The shared modules later staging work builds on stay: member-integrations and the accounts key factory. The legacy integration detail opens the saved-credential modal for Jama and Flow, which #9723 added only to the new view.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR changes organization pages and a bounded set of workspace search behavior. Remove the unused hook imports to satisfy the repository requirement before merging. SummaryRestores the legacy organization and People views while keeping later account support.
Reviews (2) · Last reviewed commit: "fix(org): keep staging's shared modules ..." · Reviewed by Greptile |
…d views Hooks, contracts, key factories and lib helpers stay at staging, and the legacy view adapts to them. Jama and Flow reconnect through the saved-credential modal and disconnect through Search. Exports only the new views used are unexported or deleted, and the e2e script returns to the legacy view's selectors.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Comments Outside DiffThese findings could not be posted inline.
|
Summary
Takes the redesigned organization view (#9708), the People page redesign (#9720) and its landing test fix (#9715) off staging, so main can keep releasing while the new UI ships all at once with #9687, which already carries all three.
After this, staging's
/oUI matches main except 6 integration files that carry functional work later PRs added to the legacy view:Only views are reverted. Hooks, contracts, key factories and lib helpers stay at staging's versions, and the legacy view adapts to them. Exports that only the redesigned views used are unexported where their own file still uses them, or deleted, so the unused-exports baseline only shrinks (2 entries).
Three API routes go: Home calendar, Home email and search-history sources. Only the new view called them, and none is on main. No reverted commit has a migration or schema change.
Merging this into #9687
#9687 already contains these commits, so a plain staging merge there would delete the org view (257 conflicting files in a dry run). After this merges, #9687 takes staging in three steps:
git merge -s ours <this squash commit>.A simulation changed 0 org-view files on #9687 and brought in every other staging commit.
Type of Change
Testing
type-checkpasses.check:test-types,explicit-any,skills, biome,test-patterns,boundaries,react-query,source-conventions,file-names,utils,client-boundary,comment-hygiene,api-validation:strict,guidance-refsandunused-exportsall pass. The unused-exports baseline shrank by one entry.app/o, all ofhooks/, credential groups, org lib, search, People,_shelland workspace Home.test-assistant-actions-e2e.tsis back at main's legacy-view selectors./oHome, Integrations (including Jama or Flow connect) and People after merge.