Skip to content

shell: close the launcher popup before opening the workspace chooser - #35

Open
perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:upstream-ready/launcher-popup-20261005
Open

perlowja wants to merge 1 commit into
singularityos-lab:mainfrom
perlowja:upstream-ready/launcher-popup-20261005

Conversation

@perlowja

@perlowja perlowja commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

toggle_workspace_overview() is the path the panel and dock use, and it never dismissed app_menu. The workspace chooser is a full-screen TOP-layer surface, so an open launcher popup was left visible underneath and occluded the menu that launched it. Dismiss app_menu first, the same way hide_overview() already does.

Verified: meson setup && meson compile clean and meson test 18/18 in a debian:forky container. Confirmed against current main (3b72f26) that toggle_workspace_overview() still lacks the dismissal.

AI assistance: disclosed

toggle_workspace_overview() is the path the panel and dock use, and it never
dismissed app_menu. The workspace chooser is a full-screen TOP-layer surface,
so an open launcher popup was left visible underneath and occluded the menu
that launched it.

Assisted-by: opencode:deepseek-flash
AI-Scope: inserted the app_menu dismissal ahead of ensure_workspace_overview() in toggle_workspace_overview().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant