Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fixes #2652 by adding the missing Sinon 20 migration section. Explain how existing XMLHttpRequest-based tests can use nise directly after the fake XHR and server APIs were unbundled.
The guide maps the removed APIs to their nise equivalents and explicitly calls out cleanup: fakes created directly through nise are not restored by a Sinon sandbox. It also distinguishes XMLHttpRequest from fetch.
How to verify - mandatory
npm ci --ignore-scriptsandnpm run build-artifactsin the repository root.npm run lintandnpx prettier --check docs/guides/migration.md.docs/, runnpm ci --ignore-scripts,npm run docs:buildandnpm run test:docs.These checks passed locally; the documentation tests reported 732 passing assertions across 251 suites. A separate nise installation was also used to verify a fake server response, the XHR factory/class mapping and explicit restoration. No library runtime files or dependencies are changed.
Checklist for author
npm run lintpassesAI assistance: Codex helped prepare the guide and run validation.