Repository navigation
Conversation
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call.
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 13, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff
Contributor
Author
|
Can you please backport it to 26 (unless 27 release is coming soon)? |
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 14, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 15, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 15, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 15, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 15, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b) (cherry picked from commit e8a4bb1)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Oct 15, 2026
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call. Closes #2200 Change-Id: Id9aaf4ab09c21f98d3dcaf78632413b99f4a97ff (cherry picked from commit b66c59b) (cherry picked from commit 472c915)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monologue_publish() never copied the offered label into the media, so sdp_create() omitted a=label from the publish answer and from subscribe requests for that publisher. Add the missing media_update_label() call.