Repository navigation
rtcp: bound per-SSRC MOS history without losing lifetime aggregates (#2174) - #2203
Closed
darwvin-dev wants to merge 9 commits into
Closed
darwvin-dev wants to merge 9 commits into
darwvin-dev wants to merge 9 commits into
Conversation
…aemon/call_interfaces.c)
Member
|
FTR this is already pending upstream: 6bd002e |
Contributor
Author
|
Thanks for pointing this out! I'll close my draft to avoid duplication Happy to contribute regression tests if useful. |
Contributor
Author
|
Closing in favor of upstream 6bd002e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-local draft for upstream #2174.
Changes
ssrc_stats_record()so the same production path is unit-testable.t/test-stats.cthat verifies queue size, lifetime MOS/jitter totals, discarded duplicate timestamp handling, and extrema timestamps from entries already evicted.MOS progressiononly describes recent samples.Validation / upstream readiness
t/test-stats.c).t/auto-daemon-tests-rtcp.pl).make asan-check; GitHub Actions are currently not running on this fork.No test execution claimed. Keep as Draft until build/ASAN passes.
Upstream submission notes
This is a draft, carried from contributor fork PR darwvin-dev/rtpengine#2.
Unfinished validation: Please refer to the outstanding build, runtime, regression and/or integration tests above. No claim is made that these checks passed. Review for compatibility and completeness before marking ready.
The source branch is behind current upstream master and may require reconciliation before merging.