Repository navigation
redis: preserve owner key when foreign restore fails (#2181) - #2204
Draft
darwvin-dev wants to merge 1 commit into
Draft
darwvin-dev wants to merge 1 commit into
darwvin-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Redis keyspace subscriber fails to restore a foreign call (for example, the subscriber lacks the owner's third logical interface),
json_restore_call()currently deletes the persisted key through the failed call cleanup and unconditional DEL commands. A misconfigured subscriber can therefore destroy the healthy owner's recoverable state.Change
redis_hosted_dbto the non-persisted sentinel beforecall_destroy()so it cannot delete an owner's key.Test plan (not yet performed)
pub2, C subscribes but lackspub2. Confirm C restore fails yet the owner's key remains present and A's recovery is unaffected.Draft until multi-node HA tests validate correctness. Related to #2181.
Upstream submission notes
This is a draft, carried from contributor fork PR darwvin-dev/rtpengine#3.
Unfinished validation: Please refer to the outstanding build, runtime, regression and/or integration tests above. No claim is made that these checks passed. Review for compatibility and completeness before marking ready.
The source branch is behind current upstream master and may require reconciliation before merging.