Repository navigation
fix(docker): require the three Compose secrets - #129
Merged
Merged
Conversation
Root Compose substituted development defaults when SITMUN_USER_SECRET, MIDDLEWARE_SECRET, or SITMUN_MBTILES_JOB_HANDLE_SECRET was unset. Setup generates them into a new .env. Profile files still do not store them. Fixes #113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SITMUN_USER_SECRET,MIDDLEWARE_SECRET, orSITMUN_MBTILES_JOB_HANDLE_SECRETis unset.setup.shandsetup.ps1generate those values into a new.envwhen the keys are absent. Profile files do not store them.tools/scripts/check-compose-secrets.shfails ifdocker compose configsucceeds without the three secrets.Test plan
bash tools/scripts/check-compose-secrets.shfailed before the:?change (config exited 0) and exits 0 after it.docker compose configwith the three secrets set exits 0 and the rendered file does not containdev-only-insecure.bash -nonsetup.sh,check-compose-secrets.sh, andverify-compose-profiles.sh(already run locally).Fixes #113