Repository navigation
fix(docker): drop the standalone postgres and oracle compose files - #130
Merged
Merged
Conversation
Those files built the backend and proxy from a context that cannot see sitmun-shared. The root Compose file already runs the same services. Fixes #110
34 of 57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profiles/postgres/docker-compose.ymlandprofiles/oracle/docker-compose.yml. Their build context cannot seesitmun-shared. The profile directories stay, because the root Compose file mounts them throughSITMUN_CONFIG_DIR.verify-compose-profiles.shnow start PostgreSQL and Oracle from the root Compose file.check-compose-secrets.shfails if either standalone file, thecd profiles/postgresinstruction, or a verify-script target for those files comes back.Test plan
cd profiles/postgresstep, and the verify-script targets were still present.bash tools/scripts/check-compose-secrets.shexits 0 after the deletion.docker compose configforprofiles/postgres.envandprofiles/oracle.envresolves the backend to context./backandbackend/Dockerfile, and the proxy toproxy/Dockerfile.Fixes #110