Repository navigation
SK-3168,SK-3204-Add-query-getTokens-uploadFiles-and-deleteFiles-to-flowvault - #435
Merged
skyflow-himanshupal merged 4 commits intoOct 9, 2026
Conversation
skyflow-himanshupal
requested review from
saileshwar-skyflow and
skyflow-bharti
October 7, 2026 09:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## flowvault-release/26.10.0 #435 +/- ##
===============================================================
+ Coverage 90.99% 91.39% +0.40%
- Complexity 0 605 +605
===============================================================
Files 174 197 +23
Lines 7350 8126 +776
Branches 1013 1132 +119
===============================================================
+ Hits 6688 7427 +739
- Misses 437 449 +12
- Partials 225 250 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Duplicate file columns, malformed unique values, sequential signed-URL uploads, and out-of-range double serialization can produce incorrect behavior.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds unary query, token lookup, file upload, and file deletion capabilities to Flow Vault while migrating the SDK to the regenerated Fern client.
Changes:
- Adds request/response models, validation, formatting, options, and signed-URL upload handling.
- Migrates generated resources from
flowservice/V1*types to records, tokens, query, and files clients. - Adds extensive tests, documentation, samples, and packaging updates.
| File | Description |
|---|---|
.cspell.json |
Adds terminology used by generated code and file-format tests. |
common/src/main/java/com/skyflow/errors/ErrorMessage.java |
Adds validation messages for the new operations. |
common/src/main/java/com/skyflow/logs/{ErrorLogs,InfoLogs}.java |
Adds operation logging messages. |
common/src/main/java/com/skyflow/vault/data/Base*.java |
Adds shared request and response base classes. |
common/src/test/java/com/skyflow/vault/data/Base*Tests.java |
Tests the new shared data classes. |
flowvault/README.md |
Documents the four unary APIs. |
flowvault/pom.xml |
Consolidates shade-plugin executions. |
flowvault/samples/src/main/java/com/example/vault/*Example.java |
Demonstrates query, token lookup, upload, and deletion. |
flowvault/src/main/java/com/skyflow/VaultClient.java |
Exposes regenerated resource clients and a signed-URL HTTP client. |
flowvault/src/main/java/com/skyflow/enums/InterfaceName.java |
Adds names for the new operations. |
flowvault/src/main/java/com/skyflow/utils/Utils.java |
Builds wire requests and formats operation responses. |
flowvault/src/main/java/com/skyflow/utils/validations/Validations.java |
Validates the new request types. |
flowvault/src/main/java/com/skyflow/vault/controller/VaultController.java |
Implements the four unary operations and file PUT workflow. |
flowvault/src/main/java/com/skyflow/vault/data/*.java |
Adds operation-specific requests, responses, records, metadata, and options. |
flowvault/src/main/java/com/skyflow/generated/rest/ApiClient.java |
Adds regenerated synchronous resource access. |
flowvault/src/main/java/com/skyflow/generated/rest/AsyncApiClient.java |
Adds regenerated asynchronous resource access. |
flowvault/src/main/java/com/skyflow/generated/rest/RawApiClient.java |
Adds regenerated raw client functionality. |
flowvault/src/main/java/com/skyflow/generated/rest/core/*.java |
Updates generated serialization, HTTP, logging, and stream support. |
flowvault/src/main/java/com/skyflow/generated/rest/errors/*.java |
Adds generated typed HTTP errors. |
flowvault/src/main/java/com/skyflow/generated/rest/resources/files/*.java |
Adds file upload and deletion clients. |
flowvault/src/main/java/com/skyflow/generated/rest/resources/query/*.java |
Adds query clients. |
flowvault/src/main/java/com/skyflow/generated/rest/resources/records/*.java |
Migrates record operations to regenerated clients. |
flowvault/src/main/java/com/skyflow/generated/rest/resources/tokens/*.java |
Migrates token operations and adds token lookup. |
flowvault/src/main/java/com/skyflow/generated/rest/types/*.java |
Replaces legacy V1* models with regenerated types. |
flowvault/src/test/java/com/skyflow/**/*.java |
Tests validation, request mapping, errors, headers, responses, and file formats. |
skyvault/pom.xml |
Consolidates shade-plugin executions. |
skyvault/src/test/java/com/skyflow/utils/logger/LogUtilTests.java |
Adds logger setup and filtering coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
saileshwar-skyflow
approved these changes
Oct 9, 2026
skyflow-himanshupal
merged commit Oct 9, 2026
086e4dd
into
flowvault-release/26.10.0
28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the four unary operations from the Java flowvault design doc —
vault().query(),vault().getTokens(),vault().uploadFiles()andvault().deleteFiles()— and migrates the flowvault SDK to the regenerated Fern client.Why
records,tokens,queryandfilesresources replaceflowserviceand theV1*types), so the existing operations were migrated to it.Goal
SELECTand returnsfields,metadata.columnsand the call'srequestId.PUT. Each column reportsUPLOADED,FAILEDorSKIPPED. AcceptsfilePath,base64orfileObject.skyflowIdoruniqueValues, returning{column, status}per record.*Optionsfor custom headers, and come withBase*classes incommon, validation, README sections and samples.sdk-integration-tests).Testing
UploadFilesFormatsTestsruns real uploads against a local HTTP server: 30 file formats × 3 sources, checking bytes,Content-Type, file name and method. It also covers a large file, an empty file, overrides, a storage-side rejection and an upload longer than the vault-call timeout.common184,skyvault575,flowvault941.Tech debt