Skip to content

docs: changelog entries told the whole story where one sentence would do - #152

Merged
skyoo2003 merged 2 commits into
mainfrom
docs/one-sentence-changelog
Sep 6, 2026
Merged

docs: changelog entries told the whole story where one sentence would do#152
skyoo2003 merged 2 commits into
mainfrom
docs/one-sentence-changelog

Conversation

@skyoo2003

@skyoo2003 skyoo2003 commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

RELEASE.md asked for "a one-line body" and nothing enforced it, so changelog entries grew into paragraphs carrying root cause, mechanism, evidence and rejected alternatives — all of which the linked issue already holds. This states the limit (one sentence, two at most), rewrites every existing entry to it, and republishes the affected GitHub Release bodies.

Related Issue

Fixes #

Changes

Guidance

  • RELEASE.md: new ### One sentence. Two at most. section under During development — one sentence for what changed and what it means, a second only for a caveat a reader must not miss, never a third (a third means two changes, or a story that belongs in the issue). Shows a too-long and a right-length body: side by side, using the fix: S3 Control requests were served by S3, silently #142 S3 Control entry.
  • RELEASE.md: pre-flight checklist gains Every fragment body is one sentence, two at most.

Rewrite

Published notes

  • gh release edit v1.1.0 / v1.0.0 --notes-file changes/<tag>.md. This does not break the "no manual GitHub Release editing" rule in RELEASE.md — the bodies were republished verbatim from the fragment-owned files, not hand-typed. Prior bodies backed up locally before the edit.

Files Changed

File Type
RELEASE.md Modified — new rule section + checklist item
changes/v1.1.0.md Modified — 38 entries rewritten
changes/v1.0.0.md Modified — 6 entries rewritten
changes/unreleased/Documentation-20260906-234500.yaml Modified — body condensed
CHANGELOG.md Modified — regenerated

Test Plan

  • Sentence-count check over every entry in changes/v*.md and changes/unreleased/*.yaml: 0 entries over the limit.
  • Replayed the release.yml notes validation against changes/v1.1.0.md locally: exactly 1 version heading naming the tag, 0 lines that are not changie output, all 38 entries ending in a valid issue link.
  • changie merge run clean; CHANGELOG.md diff is confined to the rewritten entries.
  • Published bodies diffed against changes/<tag>.md after the edit — byte-identical apart from the trailing newline GitHub appends.

No code changed, so the Go and boto3 suites are unaffected.

Checklist

  • Self-reviewed the code
  • Added/updated tests — N/A, documentation only
  • Lint/format passes (pre-commit hooks passed; golangci-lint N/A, no Go files touched)
  • Updated documentation (if applicable)
  • Added a Changie changelog fragment for user-facing changes (changes/unreleased/Documentation-20260906-185423.yaml, Issue 152)

RELEASE.md asked for "a one-line body" and nothing enforced it, so entries
grew into paragraphs: root cause, mechanism, evidence and rejected
alternatives, all of which the linked issue already holds. The v1.1.0 notes
ran 38 entries over 19KB, and a reader deciding whether the release affects
them had to read a design document to find out.

The fragment section now states the rule outright — one sentence, two only
for a caveat a reader must not miss, never a third — with a too-long and a
right-length body shown side by side, and the pre-flight checklist gained a
line for it. Every entry in v1.1.0, v1.0.0 and the unreleased #151 fragment
is rewritten to that limit; v0.2.0 and v0.1.0 already met it. CHANGELOG.md is
regenerated with `changie merge`.

The v1.1.0 and v1.0.0 GitHub Release bodies were republished from their
`changes/<tag>.md` files, so the published notes and the repo still agree.
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 6, 2026
@skyoo2003
skyoo2003 merged commit 9a5fc0a into main Sep 6, 2026
7 checks passed
@skyoo2003
skyoo2003 deleted the docs/one-sentence-changelog branch September 6, 2026 09:55
skyoo2003 added a commit that referenced this pull request Sep 6, 2026
…153)

#152 stated the rule in RELEASE.md and added a pre-flight checklist line, but
the only enforcement was a manual checkbox read once per release — and the rule
was invisible where a contributor actually lands: CONTRIBUTING.md and the PR
checklist both linked RELEASE.md without saying what the rule is.

`.changie.yaml` now sets `body.maxLength: 400`, which `changie new` refuses to
exceed (401 characters rejected, 398 accepted). It is a ceiling for the
two-sentence case rather than a target, and it does not see a hand-written
fragment — both stated in RELEASE.md beside the rule. CONTRIBUTING.md and the
PR checklist state the rule and link the section directly.

The unreleased #151 fragment ran 482 characters, over the new cap; it is
shortened to 397 with nothing dropped. The #152 fragment covers the cap and the
two added surfaces.
@skyoo2003 skyoo2003 mentioned this pull request Sep 6, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant