Skip to content

fix: stop aiohttp Socket Mode connect() retrying forever after close - #1956

Merged
WilliamBergamin merged 2 commits into
mainfrom
fix/aiohttp-socket-mode-connect-stops-when-closed
Sep 3, 2026
Merged

fix: stop aiohttp Socket Mode connect() retrying forever after close#1956
WilliamBergamin merged 2 commits into
mainfrom
fix/aiohttp-socket-mode-connect-stops-when-closed

test(socket-mode): cover connect() close-during-exception guard

13bca88
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2026 in 1s

84.08% (+0.01%) compared to 9d1d6b9

View this Pull Request on Codecov

84.08% (+0.01%) compared to 9d1d6b9

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.08%. Comparing base (9d1d6b9) to head (13bca88).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   84.06%   84.08%   +0.01%     
==========================================
  Files         118      118              
  Lines       13505    13509       +4     
==========================================
+ Hits        11353    11359       +6     
+ Misses       2152     2150       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.