Sonar on all mods - #2421
Open
nolag wants to merge 14 commits into
Open
Sonar on all mods#2421nolag wants to merge 14 commits into
nolag wants to merge 14 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Sonar workflow may proceed without the required lint report on default-branch pushes.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Expands SonarQube analysis across nested Go modules with module-specific coverage and lint reports.
Changes:
- Generates and uploads nested-module coverage.
- Downloads reports and runs SonarQube scanning explicitly.
- Updates coverage exclusions for examples.
| File | Summary |
|---|---|
sonar-project.properties |
Updated coverage exclusions. |
.github/workflows/sonar-scan.yml |
Downloads reports and runs SonarQube scanning; lint artifacts may be missing on default-branch pushes. |
.github/workflows/pkg.yml |
Generates and uploads nested-module coverage reports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jmank88
previously approved these changes
Sep 28, 2026
jmank88
reviewed
Sep 28, 2026
Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
previously approved these changes
Sep 28, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
📊 API Diff Results
|
Contributor
📊 API Diff Results
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.