CRE-6741: Add feature flag to include all timestamps in consensus - #2430
Merged
Merged
Conversation
Contributor
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The schema, defaults, and documentation consistently expose the new feature gate.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a per-workflow feature gate for including all timestamps in consensus.
Changes:
- Defines the timestamp-range setting with a disabled-by-default window.
- Updates generated defaults and settings documentation.
| File | Description |
|---|---|
pkg/settings/cresettings/settings.go |
Adds the feature setting and default range. |
pkg/settings/cresettings/README.md |
Documents the new workflow gate. |
pkg/settings/cresettings/defaults.toml |
Adds the TOML default. |
pkg/settings/cresettings/defaults.json |
Adds the JSON default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
george-dorin
approved these changes
Oct 1, 2026
mchain0
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports