Repository navigation
loop: pass beholder TracerProvider to the durable emitter - #2434
Merged
Merged
Conversation
Contributor
📊 API Diff Results
|
pkcll
force-pushed
the
loop-durable-emitter-tracing
branch
from
October 2, 2026 00:17
517d425 to
fe4e44e
Compare
This was referenced Oct 2, 2026
pkcll
force-pushed
the
loop-durable-emitter-tracing
branch
3 times, most recently
from
October 2, 2026 07:16
2c79161 to
4b4da23
Compare
pkcll
force-pushed
the
loop-durable-emitter-tracing
branch
from
October 5, 2026 22:09
4b4da23 to
a3444f6
Compare
Mirrors how the beholder Meter is passed, so the LOOP-plugin durable emitter and its chip ingress client use the beholder client's tracer provider.
…k span The retransmit link test only compared the link to the parent, so both could point at the same wrong span, and it looked up the tick immediately, which could race with the delivery callback. It now waits for the parent tick to end and asserts the parent, link and trace ID against that tick.
pkcll
force-pushed
the
loop-durable-emitter-tracing
branch
from
October 5, 2026 22:14
a3444f6 to
c770679
Compare
pkcll
marked this pull request as ready for review
October 5, 2026 22:15
pkcll
requested review from
jmank88 and
patrickhuie19
and
a balanced review from Copilot
October 5, 2026 22:15
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The provider behavior matches the documented intent, and no blocking issues remain.
Review effort: Balanced
Findings: None
What changed in this PR
Routes LOOP durable-emitter tracing through Beholder’s provider, completing the tracing integration.
Changes:
- Passes Beholder’s tracer provider to durable-emitter setup.
- Waits for the parent retransmit tick before checking span relationships.
- Updates the chipingress dependency and checksums.
| File | Description |
|---|---|
pkg/loop/server.go |
Supplies Beholder’s tracer provider. |
pkg/durableemitter/tracing_test.go |
Synchronizes and strengthens span assertions. |
go.sum |
Updates chipingress checksums. |
go.mod |
Advances the chipingress pseudo-version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
patrickhuie19
approved these changes
Oct 5, 2026
jmank88
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
skippaDaBitFlippa
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TracerProviderof the beholder client todurableemitter.Setupin the LOOP server, alongside the existingMeter, so the plugin-side durable emitter and its chip ingress client use the tracer provider of beholder.pkg/chipingressingo.modto the latestmainpseudo-versionv0.0.11-0.20261005132539-b7d63d5fd549(commit b7d63d5). No release tag is needed.PR stack
Jira: INFOPLAT-19423
Notes
beholder.GetClient()is the noop client, so its tracer provider is a noop. Durable emitter spans are then off even if tracing is enabled viaSetupTracing(same asMetertoday).bc.TracerProvideris not wrapped by the pyroscope tracer provider, so these spans are not linked to profiles whenPyroscopeLinkTracesToProfilesis on.Test plan
go build ./pkg/...,go vet,go mod tidy -diffcleango test -race ./pkg/durableemitter/ ./pkg/loop/; the retransmit link test passes 80 runs under-race