Repository navigation
Txm cap unknown error - #569
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
Krish-vemula,
Oozyx,
bolekk and
patrickhuie19
October 6, 2026 20:51
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Configuration and interface defects prevent compilation or initialization, while multiple new tests cannot exercise their intended behavior.
Review effort: Balanced
Findings: 2
Open (7)
What changed in this PR
Adds configurable limits for retrying transactions after unknown RPC errors.
Changes:
- Adds retry-count and timeout configuration.
- Updates TXM dependencies and Go version.
- Adds documentation and broadcaster tests.
| File | Description |
|---|---|
pkg/txmgr/broadcaster_test.go |
Tests retry limits and fatal transitions. |
pkg/config/toml/testdata/config-full.toml |
Adds full-config examples. |
pkg/config/toml/docs.toml |
Documents retry settings. |
pkg/config/toml/defaults/fallback.toml |
Defines fallback values. |
pkg/config/toml/config.go |
Adds TOML fields and merging. |
pkg/config/toml/config_test.go |
Extends full configuration fixture. |
pkg/config/chain_scoped_transactions.go |
Exposes configuration accessors. |
go.mod |
Updates Go and dependencies. |
go.sum |
Updates dependency checksums. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Unheilbar
marked this pull request as draft
October 6, 2026 21:07
Unheilbar
force-pushed
the
PLEX-2846_txm-cap-unkown-err
branch
from
October 6, 2026 21:17
a2f5cb2 to
3a0cfda
Compare
Contributor
|
Contributor
|
FWIW TXMv2 has this as a built-in mechanism already. |
Unheilbar
marked this pull request as ready for review
October 7, 2026 22:21
amit-momin
reviewed
Oct 13, 2026
amit-momin
approved these changes
Oct 15, 2026
ilija42
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.