Repository navigation
Bump chainlink-tron/relayer and import gotron-sdk from it - #576
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested review from
jmank88 and
matYang
October 19, 2026 22:22
Contributor
|
👋 JohnChangUK, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The import and dependency changes are consistent, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates Tron address imports to use the relayer’s bundled SDK, avoiding downstream build failures caused by reliance on a module replacement.
Changes:
- Switch writer and transmitter address imports to chainlink-tron.
- Bump the relayer dependency and update checksums.
- Remove the standalone SDK dependency and replacement.
| File | Description |
|---|---|
| pkg/writer/chain_writer.go | Uses the relayer’s address package. |
| pkg/transmitter/tron_transmitter.go | Uses the relayer’s address package. |
| go.sum | Updates relayer checksums and removes obsolete SDK entries. |
| go.mod | Bumps the relayer and removes the old SDK dependency and replacement. |
Review effort: Balanced
Contributor
📊 API Diff Results
|
Import the tron address package from chainlink-tron/relayer/gotron-sdk instead of fbsobreira/gotron-sdk, and drop the replace. chainlink-deployments-framework v0.126.0 dropped its fbsobreira/gotron-sdk replace. Any module that links both then fails to build on the tron address type.
JohnChangUK
force-pushed
the
fix/gotron-sdk-import
branch
from
October 19, 2026 22:42
83491fe to
a4fae12
Compare
jmank88
approved these changes
Oct 20, 2026
JohnChangUK
enabled auto-merge (squash)
October 20, 2026 22:02
silaslenihan
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
github.com/smartcontractkit/chainlink-tron/relayer/gotron-sdkinstead ofgithub.com/fbsobreira/gotron-sdk(pkg/transmitter/tron_transmitter.go,pkg/writer/chain_writer.go).github.com/smartcontractkit/chainlink-tron/relayertov0.0.11-0.20261013132128-58831cfe6302.fbsobreira/gotron-sdkreplace fromgo.mod.Why
chainlink-deployments-framework v0.126.0 dropped its
fbsobreira/gotron-sdkreplace (chainlink-deployments-framework#1197). Any module that links both chainlink-evm and the framework then fails to build on the tron address type. Importing the package from chainlink-tron directly removes the need for the replace.Testing
go build ./...,go vetandgo test -raceon./pkg/writer/...and./pkg/transmitter/...pass; golangci-lint v2.14.0 shows no new issues.