Repository navigation
Revert #572, downgrade go-ethereum to v1.17.4 - #581
Merged
Merged
Conversation
Contributor
📊 API Diff Results
|
Contributor
📊 API Diff Results
|
ibrajer
marked this pull request as ready for review
October 28, 2026 12:02
product-security-plaid-production
Bot
requested review from
MStreet3,
Oozyx and
ilija42
October 28, 2026 12:03
ibrajer
marked this pull request as draft
October 28, 2026 12:04
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The dependency bump to Geth v1.17.4 leaves the generated-wrapper version record at v1.17.3, causing the CI version-consistency test to fail until the wrappers and version records are regenerated and committed.
1 open issue
What changed in this PR
Aligns the wrapper modules with the root module’s go-ethereum v1.17.4, avoiding the v1.17.8 interface change ahead of the VRF cleanup in #571.
Changes:
- Downgrades helpers from go-ethereum v1.17.8 to v1.17.4 and upgrades gethwrappers from v1.17.3 to v1.17.4.
- Adjusts related dependencies and checksums in both modules.
| File | Description |
|---|---|
| gethwrappers/helpers/go.sum | Updates checksums for the helpers dependency downgrade. |
| gethwrappers/helpers/go.mod | Pins go-ethereum v1.17.4 and lowers related tooling dependencies. |
| gethwrappers/go.sum | Updates checksums for the wrapper dependency changes. |
| gethwrappers/go.mod | Bumps go-ethereum to v1.17.4 and adjusts indirect dependencies. |
Review effort: Balanced
ibrajer
marked this pull request as ready for review
October 28, 2026 12:25
RayXpub
approved these changes
Oct 28, 2026
jmank88
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #572
1.17.8 is introducing a breaking change I currently can't easily untangle and is not relevant for my upcoming cleanup PR #571
I'm downgrading to 1.17.4 because this is the version used here #559 and it doesn't contain the breaking interface change.
1.17.4 https://github.com/ethereum/go-ethereum/blob/v1.17.4/accounts/abi/bind/v2/backend.go#L107-L108
1.17.8 https://github.com/ethereum/go-ethereum/blob/v1.17.8/accounts/abi/bind/v2/backend.go#L107-L108
This would mean I need to close the following PR #573