Repository navigation
Conversation
📊 API Diff Results
|
|
There was a problem hiding this comment.
🟢 Approval recommended
The review identifies no active issues with the legacy VRF removal.
No open issues 🎉
What changed in this PR
Removes legacy VRF support from the contracts, generated Go bindings, and transaction manager while retaining VRF V2 Plus. This PR is stacked on #571, so the reviewed diff also includes VRF V1 removal and the related binding-version alignment.
Changes:
- Removes legacy VRF contracts, consumers, mocks, helpers, and associated binding-generation entries.
- Removes V1/V2 transmit checkers and renames the remaining checker to
VRFV2PlusChecker, updating tests accordingly. - Aligns CRE Go bindings and generation metadata with go-ethereum v1.17.4.
| File | Description |
|---|---|
pkg/txmgr/txmgr_test.go |
Uses the V2 Plus checker in transaction tests. |
pkg/txmgr/transmitchecker.go |
Removes legacy checkers and renames the retained checker. |
pkg/txmgr/transmitchecker_test.go |
Removes legacy tests and updates V2 Plus references. |
pkg/txmgr/models.go |
Removes V1/V2 checker constants. |
gethwrappers/go_generate_vrf.go |
Removes legacy binding-generation directives. |
gethwrappers/generated/vrfv2_wrapper_interface/vrfv2_wrapper_interface.go |
Deletes the V2 wrapper interface binding. |
gethwrappers/generated/vrf_ownerless_consumer_example/vrf_ownerless_consumer_example.go |
Deletes the V1 ownerless consumer binding. |
gethwrappers/generated/vrf_load_test_ownerless_consumer/vrf_load_test_ownerless_consumer.go |
Deletes the V1 load-test consumer binding. |
gethwrappers/generated/solidity_vrf_wrapper/solidity_vrf_wrapper.go |
Deletes the legacy VRF binding. |
gethwrappers/generated/solidity_vrf_request_id/solidity_vrf_request_id.go |
Deletes the legacy request-ID helper binding. |
gethwrappers/generated/solidity_vrf_request_id_v08/solidity_vrf_request_id_v08.go |
Deletes the Solidity 0.8 request-ID helper binding. |
gethwrappers/generated/solidity_vrf_consumer_interface/solidity_vrf_consumer_interface.go |
Deletes the legacy consumer binding. |
gethwrappers/generated/solidity_vrf_consumer_interface_v08/solidity_vrf_consumer_interface_v08.go |
Deletes the Solidity 0.8 V1 consumer binding. |
contracts/src/v0.8/vrf/VRFV2WrapperConsumerBase.sol |
Deletes the V2 wrapper consumer base. |
contracts/src/v0.8/vrf/VRFSubscriptionBalanceMonitor.sol |
Deletes the V2 subscription funding monitor. |
contracts/src/v0.8/vrf/VRFRequestIDBase.sol |
Deletes V1 request-ID generation. |
contracts/src/v0.8/vrf/VRFOwner.sol |
Deletes V2 coordinator administration utilities. |
contracts/src/v0.8/vrf/VRFConsumerBaseV2.sol |
Deletes the V2 consumer base. |
contracts/src/v0.8/vrf/VRFConsumerBase.sol |
Deletes the V1 consumer base. |
contracts/src/v0.8/vrf/testhelpers/VRFV2WrapperUnderFundingConsumer.sol |
Deletes the underfunded V2 wrapper helper. |
contracts/src/v0.8/vrf/testhelpers/VRFV2WrapperRevertingConsumerExample.sol |
Deletes the reverting V2 wrapper helper. |
contracts/src/v0.8/vrf/testhelpers/VRFV2WrapperOutOfGasConsumerExample.sol |
Deletes the out-of-gas V2 wrapper helper. |
contracts/src/v0.8/vrf/testhelpers/VRFV2WrapperLoadTestConsumer.sol |
Deletes the V2 wrapper load-test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFV2WrapperConsumerExample.sol |
Deletes the V2 wrapper consumer example. |
contracts/src/v0.8/vrf/testhelpers/VRFV2TransparentUpgradeableProxy.sol |
Deletes the V2 proxy test helper. |
contracts/src/v0.8/vrf/testhelpers/VRFV2RevertingExample.sol |
Deletes the reverting V2 consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFV2ProxyAdmin.sol |
Deletes the V2 proxy administrator helper. |
contracts/src/v0.8/vrf/testhelpers/VRFV2OwnerTestConsumer.sol |
Deletes the V2 owner test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFV2LoadTestWithMetrics.sol |
Deletes the V2 load-test metrics consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFv2Consumer.sol |
Deletes the subscription-based V2 example. |
contracts/src/v0.8/vrf/testhelpers/VRFSubscriptionBalanceMonitorExposed.sol |
Deletes the balance-monitor test helper. |
contracts/src/v0.8/vrf/testhelpers/VRFSingleConsumerExample.sol |
Deletes the subscription-owning V2 example. |
contracts/src/v0.8/vrf/testhelpers/VRFRequestIDBaseTestHelper.sol |
Deletes the V1 request-ID test helper. |
contracts/src/v0.8/vrf/testhelpers/VRFOwnerlessConsumerExample.sol |
Deletes the ownerless V1 example. |
contracts/src/v0.8/vrf/testhelpers/VRFMaliciousConsumerV2.sol |
Deletes the V2 reentrancy test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFLoadTestOwnerlessConsumer.sol |
Deletes the ownerless V1 load-test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFLoadTestExternalSubOwner.sol |
Deletes the externally funded V2 load-test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFExternalSubOwnerExample.sol |
Deletes the external-subscription V2 example. |
contracts/src/v0.8/vrf/testhelpers/VRFCoordinatorV2TestHelper.sol |
Deletes the V2 payment-calculation helper. |
contracts/src/v0.8/vrf/testhelpers/VRFConsumerV2UpgradeableExample.sol |
Deletes the upgradeable V2 consumer example. |
contracts/src/v0.8/vrf/testhelpers/VRFConsumerV2.sol |
Deletes the V2 test consumer. |
contracts/src/v0.8/vrf/testhelpers/VRFConsumer.sol |
Deletes the V1 test consumer. |
contracts/src/v0.8/vrf/test/VRFCoordinatorV2Mock.t.sol |
Deletes V2 coordinator mock tests. |
contracts/src/v0.8/vrf/mocks/VRFCoordinatorV2Mock.sol |
Deletes the V2 coordinator mock. |
contracts/src/v0.8/vrf/mocks/VRFCoordinatorMock.sol |
Deletes the V1 coordinator mock. |
contracts/src/v0.8/vrf/KeepersVRFConsumer.sol |
Deletes the automation-integrated V2 consumer. |
contracts/src/v0.8/vrf/interfaces/VRFV2WrapperInterface.sol |
Deletes the V2 wrapper interface. |
contracts/src/v0.8/vrf/interfaces/VRFCoordinatorV2Interface.sol |
Deletes the V2 coordinator interface. |
contracts/src/v0.8/vrf/interfaces/IAuthorizedReceiver.sol |
Deletes the VRF authorization interface. |
contracts/src/v0.8/vrf/BatchVRFCoordinatorV2.sol |
Deletes V2 batch fulfillment support. |
contracts/src/v0.8/vrf/AuthorizedReceiver.sol |
Deletes the VRF authorization base. |
contracts/scripts/native_solc_compile_all_vrf |
Removes compilation entries for legacy contracts. |
contracts/cre/gobindings/v2/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Records Geth 1.17.4 for V2 bindings. |
contracts/cre/gobindings/v1/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Records Geth 1.17.4 for V1 bindings. |
contracts/cre/gobindings/go.sum |
Updates dependency checksums for the upgrade. |
contracts/cre/gobindings/go.mod |
Upgrades go-ethereum and related dependencies. |
contracts/cre/gobindings/dev/generation/generated-wrapper-dependency-versions-do-not-edit.txt |
Records Geth 1.17.4 for development bindings. |
Review effort: Balanced
|
|
the diff is too big so lint fails. |
Deletes the generated Go wrappers for the VRF v2 contracts, their go:generate directives and wrapper dependency-version entries, and the VRFV2 transmit checker in pkg/txmgr. The V2 plus checker is renamed from VRFV2Checker to VRFV2PlusChecker since it is now the only VRF v2 checker remaining. The VRF v2 Solidity contracts themselves are removed in a follow-up PR and must merge after this one. Co-Authored-By: Claude Code <noreply@anthropic.com>
c1e0e94 to
c7c2da0
Compare
ibrajer
changed the title
Deletes the generated Go wrappers for the VRF v2 contracts, their go:generate directives and wrapper dependency-version entries, and the VRFV2 transmit checker in pkg/txmgr. The V2 plus checker is renamed from VRFV2Checker to VRFV2PlusChecker since it is now the only VRF v2 checker remaining.
Companion PR removes the v2 Solidity contracts themselves; the two can merge in either order (they carry identical go_generate/version-file edits).
Originally part of #571 (VRF v1 + v2 removal), split out to keep each PR's diff under GitHub's 20,000-line limit so golangci-lint's only-new-issues mode works.