Repository navigation
core/services/ocr2: wire up empty Consensus Queue plugin - #23808
Merged
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
jmank88
force-pushed
the
CRE-6009-central-queue-plugin-shell
branch
from
September 23, 2026 14:03
819de9d to
75556c9
Compare
|
|
MStreet3
reviewed
Sep 23, 2026
Comment on lines
+906
to
+907
| func (d *Delegate) maybeWrapConfigService(id, key string, lggr logger.Logger, configTracker ocrtypes.ContractConfigTracker, configDigester ocrtypes.OffchainConfigDigester, localConfig ocrtypes.LocalConfig) (ocrtypes.ContractConfigTracker, ocrtypes.OffchainConfigDigester, ocrtypes.LocalConfig, error) { | ||
| if d.ocrConfigService == nil { |
Contributor
There was a problem hiding this comment.
what's the config service used for?
Contributor
Author
There was a problem hiding this comment.
This was a pattern used by vault and donTime already, and AC 2 mentioned it:
OCRConfigService wraps the config tracker and digester when available, using the trigger queue capability ID and OCR config key.
jmank88
changed the title
|
jmank88
commented
Sep 30, 2026
| BinaryNetworkEndpointFactory: d.peerWrapper.Peer3_1, | ||
| V2Bootstrappers: bootstrapPeers, | ||
| ContractConfigTracker: configTracker, | ||
| ContractTransmitter: nil, // TODO ticket transmitter |
Contributor
Author
There was a problem hiding this comment.
Vault implementation for reference: https://github.com/smartcontractkit/chainlink/blob/6fff28e0c59ef1cc90119953a06adadd395074ca/core/services/ocr2/plugins/vault/transmitter.go
agparadiso
approved these changes
Oct 2, 2026
MStreet3
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/CRE-6009
Requires: