Repository navigation
fix(ci): ndarray feature assert handles ndarray-binding feature combos - #505
Merged
Merged
Conversation
… feature-resolution assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
Assert ndarray feature resolutionstep (from #472) asserted ndarray isabsentfor every matrix entry it did not list explicitly. #480 (via #504) added the matrix entry--features lazy-normalization,ndarray-bindings, which enables ndarray, so the assert failed onmain:The
*)fallback now checks the feature string: combos that containndarray-bindingsexpectno-std(built with--no-default-features, withoutstd), all others expectabsent.Verification
ci/check-ndarray-features.sh no-std --no-default-features --features lazy-normalization,ndarray-bindings→no-std✓absentforlazy-normalization,serde,datasets✓