Add Apple OAuth settings to AuthApp responses - #58
Conversation
There was a problem hiding this comment.
Added optional Apple OAuth fields (enabled, client ID, configured, secret-present) to the AuthApp model in app_auth.rs. These fields are optional to maintain backward compatibility with older API responses. Added a test to verify deserialization of both legacy responses without these fields and new responses including Apple OAuth settings.
Automated review by siGit Code Review · commit 30c1565 · see the review dashboard
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deserialize optional Apple configuration fields without breaking older API responses. Keep the provider secret out of the response model. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-Authored-By: siGit Code <noreply@sigit.si>
30c1565 to
99c765d
Compare
There was a problem hiding this comment.
Adds optional Apple OAuth fields to the AuthApp model with serde support for backward compatibility. Includes a test verifying deserialization of both legacy and new responses, and serialization of the new fields.
Automated review by siGit Code Review · commit 99c765d · see the review dashboard
Add optional Apple OAuth fields to the shared AuthApp response model: enabled, client ID, configured, and secret-present status. The provider secret remains absent from the response type.
Older API responses still deserialize when these fields are missing. Add a test for both old responses and responses with Apple settings.
Validation: both app_auth model tests pass, cargo fmt passes, and workspace Clippy passes with warnings denied (excluding the WASM-only crate).