Skip to content

Add Apple OAuth settings to AuthApp responses - #58

Merged
setoelkahfi merged 2 commits into
developmentfrom
feature/apple-oauth-model
Sep 30, 2026
Merged

setoelkahfi merged 2 commits into
developmentfrom
feature/apple-oauth-model

Conversation

@keypair34

Copy link
Copy Markdown
Collaborator

Add optional Apple OAuth fields to the shared AuthApp response model: enabled, client ID, configured, and secret-present status. The provider secret remains absent from the response type.

Older API responses still deserialize when these fields are missing. Add a test for both old responses and responses with Apple settings.

Validation: both app_auth model tests pass, cargo fmt passes, and workspace Clippy passes with warnings denied (excluding the WASM-only crate).

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added optional Apple OAuth fields (enabled, client ID, configured, secret-present) to the AuthApp model in app_auth.rs. These fields are optional to maintain backward compatibility with older API responses. Added a test to verify deserialization of both legacy responses without these fields and new responses including Apple OAuth settings.


Automated review by siGit Code Review · commit 30c1565 · see the review dashboard

Comment thread crates/smbcloud-model/src/app_auth.rs
Comment thread crates/smbcloud-model/src/app_auth.rs
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e0ec1d0a-36cd-42cd-a437-12768a3a6029

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@setoelkahfi
setoelkahfi self-requested a review September 30, 2026 09:50
keypair34 and others added 2 commits September 30, 2026 19:34
Deserialize optional Apple configuration fields without breaking older API responses. Keep the provider secret out of the response model.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-Authored-By: siGit Code <noreply@sigit.si>
@keypair34
keypair34 force-pushed the feature/apple-oauth-model branch from 30c1565 to 99c765d Compare September 30, 2026 17:41

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds optional Apple OAuth fields to the AuthApp model with serde support for backward compatibility. Includes a test verifying deserialization of both legacy and new responses, and serialization of the new fields.


Automated review by siGit Code Review · commit 99c765d · see the review dashboard

Comment thread crates/smbcloud-model/src/app_auth.rs
Comment thread crates/smbcloud-model/src/app_auth.rs
@setoelkahfi
setoelkahfi merged commit 1e73c99 into development Sep 30, 2026
7 checks passed
@setoelkahfi
setoelkahfi deleted the feature/apple-oauth-model branch September 30, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants