Repository navigation
Make chess views scrollable, fix chess chat duplication and unmount chess component safely when it is removed from the DOM - #15
Merged
Conversation
Currently, there is no scroll bar on chess pages after I made a change to remove the 'scrollable' wrapper which was messing up the chess layout. It seems using the 'scrollable' class instead both brings back the scroll bars and keeps the layout working properly.
Happy0
changed the title
Happy0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make chess views scrollable.
Currently, there is no scroll bar on chess pages after I made a change
to remove the 'scrollable' wrapper which was messing up the chess
layout.
It seems using the 'scrollable' class instead both brings back the
scroll bars and keeps the layout working properly.
Also fixes issue where game chat boxes would be duplicated if
the view was removed from the patchwork view cache then restored
by following this guide: https://mithril.js.org/integrating-libs.html
Also fixes issue where the app would not be loadable again if it was
removed from the cache in views.js due to inactivity then the user
went to the route again by unmounting the app when it is removed
from the DOM.
New version of ssb-chess-mithril also has upgraded the mithriljs
and chessground libraries.