Implement UNIX-style load averages - #474
Open
tavianator wants to merge 1 commit into
Open
Conversation
The existing `Scheduler#load` uses a 1-second time window, which is good for fast reactivity for things like `Idler`, but less good if you want it as a metric for health/autoscaling. Additionally, it performed the 1s time window normalization directly, which has the downside that how often you called `#load` could change how quickly the load values would update. Introduce a 1-minute, 5-minute, and 15-minute time window exponentially- weighted moving load average, similar to traditional UNIX getloadavg(3). To avoid expensive math on every fiber switch, we update these averages at most once a second. This same 1 second buffer is now used by `#load` which becomes fully read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
Scheduler#loaduses a 1-second time window, which is goodfor fast reactivity for things like
Idler, but less good if you wantit as a metric for health/autoscaling. Additionally, it performed the
1s time window normalization directly, which has the downside that how
often you called
#loadcould change how quickly the load values wouldupdate.
Introduce a 1-minute, 5-minute, and 15-minute time window exponentially-
weighted moving load average, similar to traditional UNIX getloadavg(3).
To avoid expensive math on every fiber switch, we update these averages
at most once a second. This same 1 second buffer is now used by
#loadwhich becomes fully read-only.
Types of Changes
Contribution