Skip to content

Add element selector - #20

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
add-element-selector
Sep 8, 2026
Merged

Add element selector#20
samuel-williams-shopify merged 1 commit into
mainfrom
add-element-selector

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Summary

Add Live::Element#selector, which returns an exact CSS attribute selector for the element identifier. This provides a canonical way to target generated, nested, or explicitly named elements without assuming their identifiers can be interpolated into a CSS ID selector.

Add coverage using an identifier that begins with a digit and contains selector-sensitive characters.

Validation

  • RuboCop passes
  • Documentation coverage remains 100%
  • Direct selector serialization check passes
  • Browser test suite deferred to CI because local Safari remote automation is disabled

Assisted-By: devx/7ef83274-928f-499d-b668-48449b1ff60e
@samuel-williams-shopify
samuel-williams-shopify merged commit 93363c0 into main Sep 8, 2026
36 of 42 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the add-element-selector branch September 8, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant