Repository navigation
feat: support Linux CLI battery queries with sudo - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Linux CLI support with native hidraw access and sudo-based battery queries. Document why the device needs read/write access and show sudo commands for source builds and installed binaries.
Use platform-specific hidapi features, deduplicate Linux device paths, reject incomplete report writes, and explain sudo usage on permission errors. Device permissions remain managed by the system; the CLI does not install udev rules.
Evidence
cargo build --lockedon Ubuntu failed withUnable to find libudev.After: Linux builds with
linux-native-basic-udev, without libudev development files.After: It exits with status 1 and a sudo hint;
sudo ./target/release/gbatexits with status 0 and readsBattery: 56% (charging)from a connected Logitech receiver (046d:c547). Device nodes were restored toroot:root 0600before this test.gbat --versionsucceeds without sudo.cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --locked(27 tests), andcargo build --release --locked.Checkjob.Merge Danger
Door: two-way
Reversible code and documentation changes; no device configuration or data migration.
Blast Radius: CLI
Linux selects a new HID backend. macOS retains its existing backend; complete-write validation also applies to macOS.