Repository navigation
Conversation
Arti-Dev
added this pull request to stack #85
October 3, 2026 05:07
Arti-Dev
force-pushed
the
73-CSV
branch
2 times, most recently
from
October 4, 2026 03:30
6373e0a to
71245d5
Compare
Contributor
|
please squash commits soon |
Kamal-uva
self-requested a review
October 11, 2026 19:13
Contributor
|
Could we add a test for the CSV export using both fixed-speed sweep and strategy comparison rows? It'd be good to verify that both row types export correctly, the expected fields are present, and the printed output includes the CSV file path. Maybe also test exporting each row type individually to cover those cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Literally just takes all the information we calculated and dumps it to CSV
I think that is good enough for our use case (as CSVs are usually for raw data). If you think we need other things in there lmk
Additionally if you want me to put the CSV in a different folder I'm open to doing that, file output is kind of all over the place
Testing
csv_test.pyRelated Issue
Closes #73
Stack created with GitHub Stacks CLI • Give Feedback 💬