Repository navigation
72/Plan Scoring - #93
Merged
Merged
Conversation
yknow having copilot write it and then adjusting it isn't all that bad. writing tests is lame anyways. unless it's for DSA3
Kamal-uva
force-pushed
the
72-plan-scoring
branch
from
October 22, 2026 21:08
c26f256 to
ccca5b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hello, 3am PR here. Again.
This improves the recommendation for the best speed plan. Each row is scored out of 100 (mostly), which is comprised of a few things:
There's a config.json in
sim/planningnow that allows you to weigh how important things are (just laps and soc margin at the moment). This will need some fine tuning obviously but it's a start.Testing
Some tests are in
scoring_test.py. They come with their own config settings so they should NOT break if the config file changes!Related Issue
Closes #72
Notes
This is the most subjective part of the epic, so lmk if you don't like this and we can discuss it!