Repository navigation
Internal - Add kitchen sink sdk config example - #663
Merged
Merged
Conversation
…ig to minimum required
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The configuration documentation needs to clarify transaction-name fallback precedence and context-limit units and collector precedence, including replacing the misleading 600 ms TTL example.
2 open issues
What changed in this PR
This PR adds comprehensive SDK configuration guidance and standardizes histogram aggregation for the SolarWinds metric exporter.
Changes:
- Adds a kitchen-sink configuration example and simplifies the main example for exporting to SolarWinds Observability.
- Enforces base2 exponential histograms alongside the existing delta-preferred temporality, with tests covering configuration overrides.
- Removes ignored metric aggregation settings from test and smoke-test configurations.
| File | Description |
|---|---|
smoke-tests/sdk-config.yaml |
Removes ignored metric settings. |
sdk-config.yaml |
Provides a minimal SolarWinds export configuration. |
sdk-config-kitchen-sink.yaml |
Documents supported options and example values. |
libs/shared/src/test/resources/sdk-config.yaml |
Removes ignored metric settings from shared test configuration. |
libs/shared/src/test/java/com/solarwinds/opentelemetry/extensions/config/provider/MetricExporterComponentProviderTest.java |
Tests enforced temporality and histogram aggregation. |
libs/shared/src/main/java/com/solarwinds/opentelemetry/extensions/config/provider/MetricExporterComponentProvider.java |
Sets base2 exponential histogram aggregation. |
custom/src/test/resources/sdk-config.yaml |
Removes ignored metric settings from custom test configuration. |
Review effort: Balanced
Updated context_ttl to a longer duration and added clarifications for context_max_events and context_max_backtraces. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated comment for swo_response_time to clarify fallback transaction name functionality. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…clarative config keys
jerrytfleung
reviewed
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several changes to the SolarWinds OpenTelemetry configuration and metric exporter logic to improve defaults, clarify configuration, and ensure consistent metric export behavior. The most important changes are grouped below:
Metric Exporter Behavior and Implementation:
MetricExporterComponentProvidernow always uses delta temporality and base2 exponential bucket histograms for metrics, regardless of anytemporality_preferenceordefault_histogram_aggregationsettings in the configuration. This is enforced programmatically and verified with new unit tests. [1] [2]Configuration File Updates and Documentation:
temporality_preferenceanddefault_histogram_aggregationoptions removed from themeter_providersection, reflecting that these options are ignored for the SolarWinds exporter. [1] [2] [3]sdk-config.yaml) was simplified and clarified to show only the minimum required settings for SolarWinds Observability, with improved comments and removal of unused/legacy options. [1] [2]sdk-config-kitchen-sink.yaml, was added, documenting all supported options, their defaults, and usage notes, including explicit documentation thatswo_otlpalways uses delta temporality and base2 exponential histograms.These changes ensure that users have clear, accurate configuration examples and that metric export behavior is consistent and predictable with the SolarWinds OTLP exporter.
Test services data