Repository navigation
fix config - #669
Merged
Merged
fix config#669
Conversation
xuan-cao-swi
approved these changes
Nov 5, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Java instrumentation configuration-key correction.
No open issues 🎉
What changed in this PR
Corrects the Java instrumentation configuration key from default-enabled to default_enabled across the example configuration and test fixtures.
Changes:
- Aligns all four YAML files on
instrumentation/development.java.common.default_enabled. - Preserves the configured value of
true.
| File | Description |
|---|---|
smoke-tests/sdk-config.yaml |
Corrects the key used by smoke tests. |
sdk-config-kitchen-sink.yaml |
Corrects the key in the comprehensive configuration example. |
libs/shared/src/test/resources/sdk-config.yaml |
Updates the shared-library test fixture. |
custom/src/test/resources/sdk-config.yaml |
Updates the custom-module test fixture. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test services data