Conversation
The dev middleware counted only a GET with Accept: text/html as a page request. HEAD, and GETs with */* or no Accept, got Vite's 404 where production renders the page. Use the same test as Vite's HTML fallback.
🦋 Changeset detectedLatest commit: 884571b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under
vite dev, a page answers 404 unless the request is a GET withAccept: text/html. HEAD requests and GETs withAccept: */*(curl,fetch()) or no Accept all get Vite's 404. Production answers 200 to all three.Fix
The dev middleware now counts a page request the way Vite's
htmlFallbackMiddlewaredoes: GET or HEAD, except/favicon.ico, with Accept missing, empty,text/htmlor*/*. Non-GET requests are unchanged.Verification
runHttpChecksgets three checks: HEAD,*/*and no Accept, each on/. Before the fix they fail indevandmw-devwith 404. After it they pass in all modes. The endpoint-mode check "default endpoint no longer handled" now sends the real RPC (a POST) instead of a GET, because a GET renders the page now, as in production. Fullpnpm testinexamples/start-ssrpasses:run.mjs644/644, plus the other scripts.