Merge from main - #103
Closed
kjw142857 wants to merge 4 commits into
Closed
Merge from main#103kjw142857 wants to merge 4 commits into
kjw142857 wants to merge 4 commits into
Conversation
* jvm changes * include try/catch/finally support in code generator * fix try statement logic * add parser and type checker integration * fix finally bug * add tests and fix syntax error * Patch grammar logic for throws keyword * Revert "Patch grammar logic for throws keyword" This reverts commit 8e933b6. * Patch grammar logic for throws keyword * Add fix for execption table finally logic * Add more tests * fix finally bug and missing test imports --------- Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>
* Include current and planned features in README * Update compiler README * Delete src/compiler/__tests__/tests/typeConversion.test.ts * Delete eslint.config.mjs * Add files via upload * Add files via upload --------- Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>
* Fix pre-existing lint/type errors blocking commits exception-table.ts declared ExceptionTableEntry.catchType as `any | null`, which eslint flags as a redundant union and which also masked a latent type mismatch (the field actually holds a ConstantClass, not a ClassData, until resolved). Narrow it to ConstantClass | null to match how it's populated in Attributes.ts and consumed in thread.ts. The pre-commit hook's repo-wide `eslint --fix` and `prettier --write` also picked up and applied a handful of pre-existing import-order and formatting fixes in other files that were tripping the hook. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TujL5U9Kg6vHKvRR7zryE4 * Skip PR coverage comment on push events jest-coverage-report-action tries to post a PR comment even on direct pushes to main, where no PR exists, causing the build job to fail with "Resource not accessible by integration". Only run the coverage-comment action on pull_request events, and run plain yarn test on push. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TujL5U9Kg6vHKvRR7zryE4 * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: kjw142857 <122250318+kjw142857@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix bug with emitting of finally instn before return statement * add extra test for break statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.