Repository navigation
Conversation
Describe frontend-distributed gateway proxy configuration and process-local proxy behavior. Refs sourcegraph/sourcegraph#17104 Amp-Thread-ID: https://ampcode.com/threads/T-01a19e7e-3391-7202-84d2-f3c8e1b70413 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Contributor
|
Direct preview links to pages changed in this PR: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Docs for sourcegraph/sourcegraph#17104: https://github.com/sourcegraph/sourcegraph/pull/17104
Verified against its reviewed head https://github.com/sourcegraph/sourcegraph/commit/96a55a379969436edbb74797cae7fe31d44bb812. The implementation merged as https://github.com/sourcegraph/sourcegraph/commit/97fd0cffa413fe14985adb78d4143ac9bbb0e91e.
Updates the private-network guide with frontend-only SERVICES_GATEWAY_PROXY configuration, consistent replica values, ServiceConnections distribution and restart behavior, HTTP CONNECT and optional Basic authentication, destination TLS, precedence over standard proxy settings, failure behavior, and process-local HTTPS_PROXY/HTTP_PROXY/NO_PROXY selection with localhost exceptions.
This covers only the gateway proxy change, not the separate migrator, drift endpoint, object-storage, or Redis changes.
Publication timing
Keep this draft until Robert requests publication. The implementation is merged, but release and deployment are not confirmed. Coordinate docs merge/publication with the release or weekly update that makes this behavior available to customers.
The permanent guide intentionally omits legacy migration prose. Release upgrade notes should tell customers using TELEMETRY_HTTP_PROXY that it is removed without a fallback, and direct them to frontend SERVICES_GATEWAY_PROXY or process-local HTTPS_PROXY.
Validation