Repository navigation
reimplement: WinMain 100% - #202
Merged
Merged
Conversation
gynt
force-pushed
the
reimpl/WinMain
branch
from
September 22, 2026 18:05
4668092 to
9503218
Compare
gynt
commented
Oct 5, 2026
gynt
marked this pull request as ready for review
October 5, 2026 14:22
TheRedDaemon
requested changes
Oct 5, 2026
gynt
force-pushed
the
reimpl/WinMain
branch
2 times, most recently
from
October 6, 2026 22:04
1c00e99 to
e613054
Compare
TheRedDaemon
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinMain is at 100% (the one difference is left is the security stack cookie handling, the msvc generated one doesn't match with the reccmp identified one)
It needed one header change (AI Bink video messages into an array), and conversion of a for-loop into
strlen.Outstanding differences: