Repository navigation
Repair .cpp files on main and fix outdated status lines - #269
Merged
Merged
Conversation
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 0.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 0.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
…ter mismatch, likely to a failure to reimplement one of the original loops Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 84.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 0.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
…r diffs; logic is sound Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 81.1%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
…em functional, but can not be considered done Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 55.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
… reorder mismatch, logic should be sound; Return value optimization, always needs SHC_3BB0A8C1_0x00477B00 active Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 86.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 82.4%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 0.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 46.2%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 76.5%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Measured with reccmp 0.1.7+sourcehold against Stronghold Crusader 1.41 (sha256 3bb0a8c1), with all struct resolvers and all function resolvers of the built sources enabled. Previous status line: 0.0%. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
Both files referenced field indices one higher than the generated header
declares, so neither compiled once every src/OpenSHC/**/*.cpp was added to
the build list. The addresses already agreed; only the index prefixes were
stale after the header was renumbered, so the fix is a rename:
QueueChangeGameIntensityOrBalance.cpp
field235_0x1072e8 -> field234_0x1072e8
field236_0x1072ec -> field235_0x1072ec
MenuView_General_Prepare_SwordShieldAndBorder.cpp
field225_0x106ee4 -> field224_0x106ee4
Neither file is in the committed cmake/openshc-sources.txt, which is why
the breakage went unnoticed. Verified with cl /Zs.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F2GxVJNKQs8Bd4Bqb96PFf
gynt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured with all struct resolvers and all function resolvers of the built sources enabled. Previous status line for some functions on main was 0.0%, the correct one is now written (some others have a small bump in percentage because of reccmp's new feature to count macro'd calls as matching).
Fixed two cpp files who used outdated fields.