fix(wrapper): update version check in addProxyCosmos and applyScrollingFix - #3962
Merged
Merged
Conversation
rxri
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These version checks don't work correctly for versions >
1.2.x. Because Spotify recently upgraded to1.3.xthis is now a problem.Since Spotify
1.3.0.277(for example)CosmosAsync.getwithhttp(s)protocol scheme does not work correctly (forwards the request to the native cosmos implementation instead of fetch).Idk what scrolling fix does, I just figured that this version check is also broken, so I might as well fix it in the same pr.
I tested that
CosmosAsyncand the scrolling fix not being run do still behave correctly in Spotify1.2.96.518and that they now also work withSpicetify.Platform.versionset to1.3.1.234. (I couldn't test with actual1.3.1.234because there is no1.3.xLinux build yet)