Skip to content

Fix saj-emanager brand key for the NovaCore registry - #212

Merged
davmoz merged 1 commit into
mainfrom
cursor/saj-emanager-registry-4909
Nov 4, 2026
Merged

davmoz merged 1 commit into
mainfrom
cursor/saj-emanager-registry-4909

Conversation

@davmoz

@davmoz davmoz commented Nov 4, 2026

Copy link
Copy Markdown
Member

Summary

saj-emanager 0.1.2 passes the NovaCore device-support registry check that rejected 0.1.1.

  • host.set_make("SAJ") is now host.set_make("saj"). The registry matches make against the lowercase brand key from /brands. This is the same correction the SAJ H2 driver took in 1.0.2. The catalog manufacturer string stays SAJ.
  • host.emit_metric is not a host function in that registry (FTW has it; the registry allowlist does not). The calls are gone. Device count and the phase voltage/frequency divisor are one host.log line each. Inverter, load, generator, raw battery capacity, and the FeedIn/Sell counters are not published: the first three have no stated sign, capacity is not a known Wh unit, and FeedIn versus Sell is still an open direction question.

sha256: db7692001df4fcd19130c1a7e5b0f61f425f519bf2ba92be4ae1371c345da792
size_bytes: 24245

Still read-only. Still not run on hardware.

Driver evidence

  • Driver id: saj-emanager
  • Device make/model: SAJ eManager C1 Pro
  • Firmware tested: none
  • Protocol/register source: unchanged from Add read-only SAJ eManager C1 Pro driver #210
  • Hardware test performed: none. make test-driver ID=saj-emanager and make check
  • Known limits: read-only; wire signs unverified; no metric channel for the unpublished counters

Safety

  • The driver starts read-only, or this is a separately reviewed control change.
  • Vendor signs are converted at the driver boundary.
  • Cached telemetry becomes stale instead of being re-emitted as fresh.
  • No credentials, serial numbers, private addresses or site data are included.

Control evidence

Not applicable. No writes.

  • HIL evidence or required: not applicable (read-only)
  • Control changes include default-mode, lease-expiry and HIL evidence. — not applicable

Checks

  • Commits include Signed-off-by.
  • make test-driver ID=saj-emanager
  • make check
Open in Web Open in Cursor 

NovaCore rejects set_make("SAJ") and does not provide emit_metric.
Device count and the phase divisor are logged once instead.

Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: David Mozart <davmoz@users.noreply.github.com>
@davmoz
davmoz merged commit 8747378 into main Nov 4, 2026
5 checks passed
@davmoz
davmoz deleted the cursor/saj-emanager-registry-4909 branch November 4, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants