Repository navigation
Fix saj-emanager brand key for the NovaCore registry - #212
Merged
Merged
Conversation
NovaCore rejects set_make("SAJ") and does not provide emit_metric.
Device count and the phase divisor are logged once instead.
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: David Mozart <davmoz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saj-emanager0.1.2 passes the NovaCore device-support registry check that rejected 0.1.1.host.set_make("SAJ")is nowhost.set_make("saj"). The registry matches make against the lowercase brand key from/brands. This is the same correction the SAJ H2 driver took in 1.0.2. The catalog manufacturer string staysSAJ.host.emit_metricis not a host function in that registry (FTW has it; the registry allowlist does not). The calls are gone. Device count and the phase voltage/frequency divisor are onehost.logline each. Inverter, load, generator, raw battery capacity, and the FeedIn/Sell counters are not published: the first three have no stated sign, capacity is not a known Wh unit, and FeedIn versus Sell is still an open direction question.sha256:
db7692001df4fcd19130c1a7e5b0f61f425f519bf2ba92be4ae1371c345da792size_bytes: 24245
Still read-only. Still not run on hardware.
Driver evidence
make test-driver ID=saj-emanagerandmake checkSafety
Control evidence
Not applicable. No writes.
required: not applicable (read-only)Checks
Signed-off-by.make test-driver ID=saj-emanagermake check