Repository navigation
fix(drivers): bundle zap 3.1.3, read_pv and read_battery work on firmware 7.x - #1962
Merged
Merged
Conversation
…ware 7.x Moves the pin to srcfl/device-drivers@e463c653 (#209). Only the Zap driver changes. The new tests use the payload a Zap on 7.0.3 sent for a simulated Solis. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: David Mozart <dmozartandraws@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1961 brought the Zap's site meter back on firmware 7.x.
read_pvandread_batterystill read nothing there, because 7.x renamed those fields too.Change
mainthere was at the current pin before that merge, so onlyzapchanges.#1792 also changes
drivers/BUNDLED_SOURCE.json, with a pin from before these. It will need rebasing onto the current pin.Tested
go test ./internal/drivers/ -run Zapand./internal/fleetping/pass.scripts/sync-bundled-drivers.sh --checkand--behindpass.read_pvandread_battery: meter -1100 W, PV -3000 W, battery +5000 W.Not tested on a real inverter or a full FTW site. The firmware and its payloads are real; the Solis is not.
🤖 Generated with Claude Code