Repository navigation
Fork-mode canary (re-run on 2.44.1): collapse repeated separators in s - #1
Open
stackbilt-admin wants to merge 2 commits into
Open
stackbilt-admin wants to merge 2 commits into
stackbilt-admin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Automated, sandboxed change from task 2e2e6ff1-26d4-41ea-9487-7a73278599cf. The executor retained branch and publication authority.
Harness summary:
Fixed the slugify bug and added the regression test.
Changes:
src/slugify.ts: changed the replacement regex from/[^a-z0-9]/gto/[^a-z0-9]+/gso runs of non-alphanumeric characters collapse to a single dash.tests/slugify.test.ts: added the testcollapses runs of separators into one dashwith both required assertions.Verification:
pnpm exec vitest run tests/slugify.test.tspassed with 4 tests.Acceptance: 6/6 checks passed (re-run by the executor, not reported by the model).
changed_files_only— changed: src/slugify.ts, tests/slugify.test.tschanged_files_required— all required files changedmax_added_lines— 6 added (limit 15)max_deleted_lines— 1 deleted (limit 3)file_contains— tests/slugify.test.ts contains "collapses runs of separators into one dash"tests— pnpm exec vitest run tests/slugify.test.ts: exit 0, 4 passed, 0 failed (expected 4 passed)