Repository navigation
Conversation
The coverage tooling path still resolved js-yaml 3.14.2, which is affected by merge-key denial-of-service advisories fixed in 3.15.2. The existing ^3.13.1 range already allows that release. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
closed because this was solved with dependabot resolver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the remaining vulnerable
js-yamlinstall.js-yaml@4.3.2was already on the patched 4.x release.js-yaml@3.14.2, used only to load Istanbul/nyc coverage config, was still affected by merge-key denial-of-service advisories. It is now3.15.2.Advisories fixed for the 3.14.2 install:
maxTotalMergeKeys. Fixed in 3.15.2 and 4.3.2.CVE-2025-64718 does not apply to 3.14.2 (patched in 3.14.2). The 5.x advisories do not apply because 5.x is not installed.
This is coverage/test tooling, not the published React Native runtime.
load-nyc-configparses local nyc YAML during Jest instrumentation. Attacker-controlled YAML is not on the library's user path. The lockfile still contained an affected version, so it is updated.Dependency path
Transitive, example workspace, test/coverage tooling:
babel-jestalso depends onbabel-plugin-istanbuldirectly. Both paths resolve the samejs-yaml3.x install.Other installs were already
js-yaml@4.3.2through@eslint/eslintrc,cosmiconfig,read-yaml-file, andsemantic-release-yarn. Those ranges stay on 4.3.2, the latest patched 4.x release.Package-only investigation
@istanbuljs/load-nyc-config@1.1.0requestsjs-yaml@^3.13.1, which includes 3.15.2.yarn up -R js-yamlmoved only that descriptor from 3.14.2 to 3.15.2. The 4.x descriptor stayed at 4.3.2.Parent investigation
No non-breaking parent update changes this dependency.
@istanbuljs/load-nyc-configis already at its latest release, 1.1.0, and still declaresjs-yaml@^3.13.1.babel-plugin-istanbul@6.1.1is the version selected by Jest 29 (^6.1.1). Even currentbabel-plugin-istanbul@8.0.2still depends on@istanbuljs/load-nyc-config@^1.0.0, so a parent bump does not move thejs-yamlrange.babel-jestand@jest/transformare already at 29.7.0, the latest 29.x release pulled in byreact-native@0.84.0.^3.13.1range.The parent update was not applied because it cannot select the fixed version. The supported fix is the lockfile resolution already allowed by the parent range.
Final remediation
yarn.lockonly:js-yaml@^3.13.1now resolves to 3.15.2.Why
Package-only is the smallest supported change. It reaches the fixed 3.x release inside the existing range, leaves the already-patched 4.3.2 installs unchanged, and does not require a parent or toolchain upgrade.
Validation
yarn installyarn why js-yamlshows 3.15.2 and 4.3.2 onlyyarn test(22 tests passed)yarn lintyarn npm audit -A -Rreports nojs-yamlfindingsScope
This PR only remediates
js-yaml. No other vulnerabilities are included.Test plan
yarn why js-yamlshows 3.15.2 for@istanbuljs/load-nyc-configand 4.3.2 everywhere elseyarn testyarn lintyarn npm audit -A -Rhas nojs-yamladvisory