Conversation
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EDGEZERO__STORES__...variables from the deployer's selected GitHub Environment control each deployment.EDGEZERO_FASTLY_BUILD_SETTINGSwhile retaining optional typed secret paths from Support optional typed secret paths and Fastly store mappings #344.Changes
edgezero-adapter/edgezero-cliedgezero-adapter-fastlyedgezero_runtime_env, reconcile production selectors after deploy, and use one per-service staging twin linked to the staged draft. Staging also links each selected physical Config, KV, and Secret Store.FASTLY_SERVICE_IDfallback, optional secrets, and action-script behavior.Deploys remain serialized per Fastly service. If an operator deletes or mutates a selected resource during a deploy, the provider operation fails clearly; this change does not introduce version-specific selector stores or recovery machinery for concurrent external mutation.
Closes
Closes #380
Test plan
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"wasm32-wasip1(Fastly) /wasm32-wasip2(Spin) /wasm32-unknown-unknown(Cloudflare) — verifiedcargo check -p edgezero-adapter-spin --target wasm32-wasip2 --features spinexamples/app-demoworkspace:cd examples/app-demo && cargo test --workspace --all-targetscd docs && npm run lint && npm run format && npm run buildedgezero serve --adapter axum(the pre-rewriteedgezero-cli devwas renamed; see cli-reference).github/actions/deploy-core/tests/run.sh(263 passed, 0 failed, 4 platform skips);git diff --checkChecklist
{id}syntax (not:id)edgezero_core(nothttpcrate)KvRegistry/ConfigRegistry/SecretRegistry(not the legacy single-handle setters) — see spec §6.6