Skip to content

execCommand mistakenly removes empty content at the beginning and end of a file. #463

Closed
Closed
execCommand mistakenly removes empty content at the beginning and end of a file.#463
Labels
bug

Description

@TerryChan
TerryChan
opened on Apr 25, 2023

When I used the execCommand method to execute the git command "git show --textconv HEAD:README.md" in order to retrieve the content of a file, I noticed that it trimmed any empty lines at the beginning and end of the file.

This issue has been reported in ssh2 and more details can be found there. But it's not issue of ssh2.

Activity

  1. steelbrain
    added
    bug
    on Apr 30, 2023

  2. steelbrain commented on Apr 30, 2023

    @steelbrain
    steelbrain
    on Apr 30, 2023
    Owner

    I would be happy to accept a PR for this (along with some test cases)!

  3. szakharchenko commented on Aug 18, 2023

    @szakharchenko
    szakharchenko
    on Aug 18, 2023

    For what it's worth, the output gets trimmed here.

  4. fuleinist
    added a commit that references this issue on May 17, 2026

    test: add unit tests for noTrim option in execCommand

    ebf512e

  5. steelbrain commented on Jun 29, 2026

    @steelbrain
    steelbrain
    on Jun 29, 2026
    Owner

    Fixed by #485

  6. steelbrain
    closed this as completedon Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions