Repository navigation
feat(contract): support addresses, numbers, and JSON for --key storage lookups - #2852
Closed
jdjioe5-cpu wants to merge 1 commit into
Closed
jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #2041.
Enhance
--keyin contract storage commands (read,restore,extend) so that it can parse more than just plainSymbolkeys.--keynow supports:G...,C...,M...), parsed intoScVal::Address{"u64": 123456789})42,true)Symbolprimitive parsing for existing plain string symbolsWhy
Previously,
--keywas hardcoded to only acceptScSpecTypeDef::Symbol:This forced developers looking up storage entries keyed by addresses, integers, or complex values to either write manual scripts or use the base64-encoded
--key-xdroption, which was inconvenient and unintuitive.How
parse_key_arg(key_str: &str) -> Result<ScVal, Error>.stellar_strkey::Strkey.json_to_scval) converting JSON numbers, booleans, arrays (ScVal::Vec), and maps (ScVal::Map).soroban_spec_tools::from_string_primitive(..., Symbol)preserving complete backward compatibility.