Skip to content

feat(typescript): add default export for Client class in generated bindings #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdjioe5-cpu wants to merge 1 commit into from
Closed

feat(typescript): add default export for Client class in generated bindings #2864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/crates/soroban-spec-typescript/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ export class Client extends ContractClient {{
public readonly fromJSON = {{
{from_jsons}
}}
}}"#,
}}
export default Client;"#,
)
}

Expand Down Expand Up @@ -737,6 +738,15 @@ mod tests {
assert!(!result.contains(METHOD_TEST));
}

#[test]
fn test_generate_includes_export_default_client() {
let output = generate(&[]);
assert!(
output.contains("export default Client;"),
"Generated TypeScript bindings must include 'export default Client;'"
);
}

#[test]
fn test_validate_npm_package_name_valid() {
assert!(validate_npm_package_name("my-contract").is_ok());
Expand Down