You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore(deps): bump substrait packages to 0.103.1 - #299
Bumps substrait-protobuf, substrait-extensions, and substrait-antlr to spec v0.103.1 (release notes).
The only change is that quantile now declares its distribution argument as any1 and returns LIST?<any1> instead of an unbound LIST?<any>. The registry could not derive a return type from the unbound any, so quantile lookups previously failed to resolve; they now resolve to a list of the distribution's type. The compact signature is unchanged. A regression test covers the new lookup.
Reviewing files that changed from the base of the PR and between b812394 and 9169bd0.
⛔ Files ignored due to path filters (2)
pixi.lock is excluded by !**/*.lock
uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
pyproject.toml
tests/extension_registry/test_registry_lookup.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Summary
Summary by CodeRabbit
Bug Fixes
Fixed arithmetic quantile lookup so it resolves with the expected nullable list result type.
Chores
Updated Substrait dependencies to version 0.103.1.
Walkthrough
The project dependency pins move from Substrait 0.103.0 to 0.103.1. A registry lookup test checks the return type of arithmetic quantile.
Changes
Substrait 0.103.1 Update
Layer / File(s)
Summary
Dependency pins and quantile lookup test pyproject.toml, tests/extension_registry/test_registry_lookup.py
The project, optional, and development dependency pins use version 0.103.1. A regression test checks that arithmetic quantile resolves to a nullable list of non-nullable fp64.
The dependency update and quantile type regression check show no actionable merge-blocking risk in the reviewed changes.
Pre-merge checks | 4 | 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 …
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Title check
The title is a valid Conventional Commit and clearly identifies the dependency update to Substrait packages version 0.103.1.
Description check
The description provides the issue reference, rationale, affected dependencies, functional impact of the quantile change, and regression-test coverage. It satisfies the available template requiremen…
Linked Issues check
Issue #273 requires an update to Substrait v0.103.1. pyproject.toml updates substrait-protobuf, substrait-extensions, and substrait-antlr from 0.103.0 to 0.103.1. The regression test in `tests…
Out of Scope Changes check
The changes are limited to the three dependency updates required by issue #273 and a regression test for the affected quantile lookup. The test directly supports the dependency update and does not a…
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)
Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273.
Bumps
substrait-protobuf,substrait-extensions, andsubstrait-antlrto spec v0.103.1 (release notes).The only change is that
quantilenow declares itsdistributionargument asany1and returnsLIST?<any1>instead of an unboundLIST?<any>. The registry could not derive a return type from the unboundany, soquantilelookups previously failed to resolve; they now resolve to a list of the distribution's type. The compact signature is unchanged. A regression test covers the new lookup.🤖 Generated with AI