Repository navigation
fix: update ruff to 0.16 and address its lint findings - #305
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 3 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 55.74% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 235 functions across 30 files. (2 skipped… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title is a concise Conventional Commit message and accurately summarizes the Ruff update and lint fixes. Description check The description provides the rationale, identifies the main fixes, and explains the intentional lint-rule exceptions. No required information is missing for this non-breaking change. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 55.74% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 235 functions across 30 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
nielspardon
force-pushed
the
style/ruff-0.16-lint
branch
from
October 13, 2026 06:53
15121a1 to
1e9d04c
Compare
nielspardon
changed the title
ruff 0.16 turns on a much larger default rule set, so bumping the pixi pin needs these fixes alongside it. Two of the findings were real bugs: - `substrait.narwhals.__all__` listed the classes instead of their names, so `from substrait.narwhals import *` raised a TypeError. - `test_wildcard_match` passed the builtin `bool()` (i.e. `False`) instead of the `boolean()` type builder, so it never exercised a boolean argument. TRY002/TRY004 are ignored rather than fixed: the public API raises plain `Exception`, and moving to typed exceptions is a separate, user-visible change. DTZ001 is ignored in tests, where naive datetimes model Substrait's timezone-less timestamps.
nielspardon
force-pushed
the
style/ruff-0.16-lint
branch
from
October 13, 2026 06:54
1e9d04c to
8d3c242
Compare
Member
Author
|
@coderabbitai resume |
✅ Action performedReviews resumed and review finished. |
andrew-coleman
approved these changes
Oct 13, 2026
# Conflicts: # pixi.lock # tests/extension_registry/test_registry_lookup.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff 0.16 turns on a much larger default rule set, so bumping the pixi pin
needs these fixes alongside it.
Two of the findings were real bugs:
substrait.narwhals.__all__listed the classes instead of their names,so
from substrait.narwhals import *raised a TypeError.test_wildcard_matchpassed the builtinbool()(i.e.False) instead ofthe
boolean()type builder, so it never exercised a boolean argument.TRY002/TRY004 are ignored rather than fixed: the public API raises plain
Exception, and moving to typed exceptions is a separate, user-visiblechange. DTZ001 is ignored in tests, where naive datetimes model Substrait's
timezone-less timestamps.