Repository navigation
Record the Mac's device key item layout in ADR 0013 - #297
Merged
Merged
Conversation
#287 authenticates each Secure Enclave key item with an HMAC tag under a key derived from the vault key, so blobs another process planted before the first pairing are refused. ADR 0013 described the paired-device list tag but not the key items; record the layout next to the key storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0013 specifies the HMAC tag of the Mac's paired-device list but not of the Secure Enclave key items. #287 (PR #296) added a tag to each key item after its cross review, because any process on the Mac can use a blob it holds and could plant usable blobs before the first pairing. This records that layout next to the key storage in ADR 0013, matching
DeviceKeyBlobAuthenticationinSources/AskKeyVault/Vault+Devices.swift.Docs only; no code change.
python3 scripts/check_hygiene.py: passes